EConvertError

[Lena]

In StrToFloat I got EConvertError.

Is it correct fix like this:

Code: Select all

String JsonMemberArraySensValue = JSONPair->JsonValue->ToString();
wchar_t FS = FormatSettings.DateSeparator;
                  try
                   {
                    FormatSettings.DecimalSeparator = '.';
                    double d = 0;
                    JsonMemberArraySensValue = StringReplace(JsonMemberArraySensValue, ",", ".",TReplaceFlags()<<rfReplaceAll<<rfIgnoreCase);
                    bool chek = TryStrToFloat(JsonMemberArraySensValue,d);
                    if(chek)
                     temperature = d;
                    }
                    __finally
                        {
                         FormatSettings.DateSeparator = FS;
                        }


No error now.

[rlebeau]

In StrToFloat I got EConvertError.

You are not using StrToFloat(), you are using TryStrToFloat() instead, which does not raise an exception on failure.

Is it correct fix like this

No. The global FormatSettings structure is not thread-safe. You should instead create a local TFormatSettings variable and customize it as needed, and then pass it to (Try)StrToFloat() as an input parameter (even without threads involved, I would still suggest doing things this way when performing customized parsing):

Code: Select all

TFormatSettings Fmt = TFormatSettings::Create(); // get default settings first...
Fmt.DecimalSeparator = ','; // now customize...
// no need for StringReplace()...
double d = 0;
if (TryStrToFloat(JSONPair->JsonValue->ToString(), d, Fmt))
    temperature = d;


[Lena]

Thank you very much!